Messages in this thread | | | Date | Thu, 21 Nov 2013 12:40:06 +0200 | From | Mika Westerberg <> | Subject | Re: [PATCH v2 2/3] gpiolib: append SFI helpers for GPIO API |
| |
On Wed, Nov 20, 2013 at 04:31:35PM +0200, Andy Shevchenko wrote: > diff --git a/include/linux/gpio/sfi.h b/include/linux/gpio/sfi.h > new file mode 100644 > index 0000000..3e111ad > --- /dev/null > +++ b/include/linux/gpio/sfi.h > @@ -0,0 +1,37 @@ > +#ifndef _LINUX_SFI_GPIO_H_ > +#define _LINUX_SFI_GPIO_H_ > + > +#include <linux/err.h> > +#include <linux/errno.h> > +#include <linux/gpio/consumer.h> > +#include <linux/sfi.h> > + > +#ifdef CONFIG_GPIO_SFI > + > +struct gpio_desc *sfi_get_gpiod_by_name(const char *name);
I'm wondering should this function be exported at all? What the drivers should be using is gpiod_get_xxx() APIs and not DT/ACPI/SFI specific interfaces.
Yeah, we have the same in ACPI version but I'm planning to get rid of it completely.
| |