lkml.org 
[lkml]   [2013]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] xen: tmem: rmove useless parameters
>>> On 20.11.13 at 10:22, Bob Liu <bob.liu@oracle.com> wrote:
> On 11/20/2013 05:10 PM, Jan Beulich wrote:
>>>>> On 20.11.13 at 09:52, Bob Liu <lliubbo@gmail.com> wrote:
>>> @@ -100,9 +100,6 @@ static inline int xen_tmem_op(u32 tmem_cmd, u32
> tmem_pool, struct tmem_oid oid,
>>> op.u.gen.oid[1] = oid.oid[1];
>>> op.u.gen.oid[2] = oid.oid[2];
>>> op.u.gen.index = index;
>>> - op.u.gen.tmem_offset = tmem_offset;
>>> - op.u.gen.pfn_offset = pfn_offset;
>>> - op.u.gen.len = len;
>>
>> But you can't leave these fields uninitialized.
>>
>
> Oh, yes.
> And I should remove those members totally from struct tmem_op {}

That's an established ABI - you can't just remove members there.

Jan



\
 
 \ /
  Last update: 2013-11-20 10:41    [W:0.035 / U:2.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site