Messages in this thread | | | Date | Wed, 20 Nov 2013 10:09:43 +0100 | From | Daniel Lezcano <> | Subject | Re: [PATCH] clksrc-of: warn if no clock sources are found |
| |
On 11/20/2013 09:58 AM, Linus Walleij wrote: > Many platforms rely on clocksource_of_init() being implicitly > called for registering clock sources and will get zero warnings > if no working clock source is available. Let's print a critical > error message if no clock source is found. > > Acked-by: Lee Jones <lee.jones@linaro.org> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
+1.
Added Stephen Warren in Cc.
> --- > drivers/clocksource/clksrc-of.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/clocksource/clksrc-of.c b/drivers/clocksource/clksrc-of.c > index 35639cf4e5a2..a30b42c3ac3b 100644 > --- a/drivers/clocksource/clksrc-of.c > +++ b/drivers/clocksource/clksrc-of.c > @@ -28,6 +28,7 @@ void __init clocksource_of_init(void) > struct device_node *np; > const struct of_device_id *match; > clocksource_of_init_fn init_func; > + unsigned clocksources = 0; > > for_each_matching_node_and_match(np, __clksrc_of_table, &match) { > if (!of_device_is_available(np)) > @@ -36,5 +37,8 @@ void __init clocksource_of_init(void) > init_func = match->data; > init_func(np); > of_node_put(np); > + clocksources++; > } > + if (!clocksources) > + pr_crit("%s: no matching clocksources found\n", __func__); > } >
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |