lkml.org 
[lkml]   [2013]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: imx-drm: Fix modular build of DRM_IMX_IPUV3
On Tue, Nov 19, 2013 at 08:56:59PM -0500, Josh Boyer wrote:
> On Mon, Nov 18, 2013 at 10:03:10AM +0100, Sascha Hauer wrote:
> > On Tue, Nov 12, 2013 at 12:15:45PM -0500, Josh Boyer wrote:
> > > commit b8d181e408af (staging: drm/imx: add drm plane support) added a file
> > > to the make target for DRM_IMX_IPUV3 but didn't adjust the objs required
> > > to actually build that as a module. Kbuild got confused and this lead to
> > > link errors like:
> > >
> > > ERROR: "ipu_plane_disable" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined!
> > > ERROR: "ipu_plane_enable" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined!
> > >
> > > Additionally, it added a call to imx_drm_crtc_id which also fails with a
> > > link error as above. To fix this, we adjust the make target with the proper
> > > objs, which will change the name of the resulting .ko. We also add an
> > > EXPORT_SYMBOL_GPL for imx_drm_crtc_id.
> > >
> > > Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
> >
> >
> > Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
> >
> > Sascha
>
> Thanks. So who picks this fix up? Greg, is that you?

Yes, I will once 3.13-rc1 is out.

greg k-h


\
 
 \ /
  Last update: 2013-11-20 07:01    [W:0.054 / U:2.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site