Messages in this thread |  | | Date | Wed, 20 Nov 2013 09:33:09 +0100 | From | Daniel Lezcano <> | Subject | Re: [PATCH v2 01/03] clocksource: Add Kconfig entries for CMT, MTU2, TMU and STI |
| |
On 11/14/2013 01:40 PM, Arnd Bergmann wrote: > On Wednesday 13 November 2013, John Stultz wrote: >>> +config EM_TIMER_STI >>> + bool "STI timer driver" >>> + default y if ARM >>> + help >>> + This enables build of the STI timer driver. >> >> >> So since I do want to avoid adding user-selectable configs if >> possible, here are some concrete thoughts on this patch, trying to >> provide an example from my more abstract rants down thread. :) > > I think we should be using the CONFIG_BUILD_TEST (or whatever > it's called) here to allow building the drivers everywhere but > at the same time be specific with the platform. How about this: > > config EM_TIMER_STI > bool "Renesas EMMA EV2 STI timer driver" if BUILD_TEST && !ARCH_EMEV2 > default ARCH_EMEV2 > help > ... > > This makes it a silent option that is set correctly all the time > but lets you enable it everywhere when BUILD_TEST is set.
It sounds like a good compromise.
> We could skip the "&& !ARCH_EMEV2" part to allow building an > EMEV2 kernel without this driver when build testing if that > is possible.
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |