Messages in this thread | | | Date | Wed, 20 Nov 2013 21:57:48 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [patch 4/6] ia64: Use preempt_schedule_irq |
| |
On Wed, 20 Nov 2013, Tony Luck wrote:
> On Tue, Sep 17, 2013 at 11:53 AM, Thomas Gleixner <tglx@linutronix.de> wrote: > > Use the proper core function instead of fiddling with PREEMPT_ACTIVE > > and enable/disable interrupts in the low level code. > > > > Index: linux-2.6/arch/ia64/kernel/entry.S > > =================================================================== > > --- linux-2.6.orig/arch/ia64/kernel/entry.S > > +++ linux-2.6/arch/ia64/kernel/entry.S > ... > > - br.call.spnt.many rp=schedule > > + br.call.spnt.many rp=preempt_schedule_irq > > This just hit mainline ... and I'm getting > > arch/ia64/kernel/built-in.o: In function `skip_rbs_switch': > (.text+0xef2): undefined reference to `preempt_schedule_irq' > make: *** [vmlinux] Error 1
Hrmpf.
> Probably because I have CONFIG_PREEMPT=n, and there seems only > to be a definition for this function in kernel/sched/core.c when it is =y.
Bah. I probably compiled that with preempt=y ...
> Do we need a stub for the =n case: > > asmlinkage void __sched preempt_schedule_irq(void) > { > schedule(); > } > > Or is life more complicated than that?
Hmm, I think I fubared that and you decided to ignore my patch :)
Let me look at it tomorrow morning with full awake brain cells.
Thanks,
tglx
| |