lkml.org 
[lkml]   [2013]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [kconfig] update: results of some syntactical checks
    From
    Date
    On Sun, 2013-10-20 at 00:03 +0200, Martin Walch wrote:
    > drivers/media/common/siano/Kconfig:21-26
    > > config SMS_SIANO_DEBUGFS
    > > bool "Enable debugfs for smsdvb"
    > > depends on SMS_SIANO_MDTV
    > > depends on DEBUG_FS
    > > depends on SMS_USB_DRV
    > > depends on CONFIG_SMS_USB_DRV = CONFIG_SMS_SDIO_DRV
    >
    > The last line adds the dependency CONFIG_SMS_USB_DRV = CONFIG_SMS_SDIO_DRV.
    > This expression does not look sound as those two symbols are not declared
    > anywhere. So, the two strings CONFIG_SMS_USB_DRV and CONFIG_SMS_SDIO_DRV
    > are compared, yielding always 'n'. As a result, SMS_SIANO_DEBUGFS will never
    > be enabled.

    Those are obvious typos. Still present in v3.12-rc7. Perhaps you'd like
    to send the trivial patch to fix this?

    > Probably, it was meant to say something like
    > > depends on SMS_USB_DRV = SMS_SDIO_DRV
    >
    > Two other config sections that probably behave differently than expected:
    >
    > drivers/staging/rtl8188eu/Kconfig: 13-15
    > > config 88EU_AP_MODE
    > > bool "Realtek RTL8188EU AP mode"
    > > default Y
    >
    > drivers/staging/rtl8188eu/Kconfig: 21-23
    > > config 88EU_P2P
    > > bool "Realtek RTL8188EU Peer-to-peer mode"
    > > default Y
    >
    > The capital Y is different from the lowercase y. While y is an actually
    > hard coded constant symbol, Y is undeclared and evaluates to n.
    > The default values are probably only for convenience, so 88EU_AP_MODE and
    > 88EU_P2P are activated together with 8188EU. They still can be turned off.
    > Anyway, it should probably say "default y" in both cases.

    Ditto.


    Paul Bolle



    \
     
     \ /
      Last update: 2013-11-02 20:41    [W:3.222 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site