lkml.org 
[lkml]   [2013]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH net-next 13/13] scripts/checkpatch.pl: Add dev_kfree_skb*(NULL) check to checkpatch
    Date
    Signed-off-by: Govindarajulu Varadarajan <govindarajulu90@gmail.com>
    ---
    scripts/checkpatch.pl | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
    index 66cad50..e651b8a 100755
    --- a/scripts/checkpatch.pl
    +++ b/scripts/checkpatch.pl
    @@ -3719,7 +3719,7 @@ sub process {
    # check for needless "if (<foo>) fn(<foo>)" uses
    if ($prevline =~ /\bif\s*\(\s*($Lval)\s*\)/) {
    my $expr = '\s*\(\s*' . quotemeta($1) . '\s*\)\s*;';
    - if ($line =~ /\b(kfree|usb_free_urb|debugfs_remove(?:_recursive)?)$expr/) {
    + if ($line =~ /\b(kfree|dev_kfree_skb|dev_kfree_skb_any|dev_kfree_skb_irq|usb_free_urb|debugfs_remove(?:_recursive)?)$expr/) {
    WARN('NEEDLESS_IF',
    "$1(NULL) is safe this check is probably not required\n" . $hereprev);
    }
    --
    1.8.4.2


    \
     
     \ /
      Last update: 2013-11-02 15:21    [W:4.474 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site