Messages in this thread | | | Date | Tue, 19 Nov 2013 10:29:02 +0100 | Subject | Re: [RFC 01/23] gpio/omap: raw read and write endian fix | From | Linus Walleij <> |
| |
On Sat, Nov 16, 2013 at 1:01 AM, Taras Kondratiuk <taras.kondratiuk@linaro.org> wrote:
> From: Victor Kamensky <victor.kamensky@linaro.org> > > All OMAP IP blocks expect LE data, but CPU may operate in BE mode. > Need to use endian neutral functions to read/write h/w registers. > I.e instead of __raw_read[lw] and __raw_write[lw] functions code > need to use read[lw]_relaxed and write[lw]_relaxed functions. > If the first simply reads/writes register, the second will byteswap > it if host operates in BE mode. > > Changes are trivial sed like replacement of __raw_xxx functions > with xxx_relaxed variant. > > Signed-off-by: Victor Kamensky <victor.kamensky@linaro.org> > Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org>
Since I generally just dislike __raw accessors I went and applied this. If it collides with any of Tony's fixup work I might need to take the patch out again, no big deal.
Some ACKs would be nice, but unless there are major objections this stays merged.
Yours, Linus Walleij
| |