Messages in this thread | | | Date | Wed, 20 Nov 2013 10:18:04 +0530 | Subject | Re: IPv6: Blackhole route support partial ? | From | Kamala R <> |
| |
Hi,
I have sent across the patch on a separate thread. The subject of the mail is :
[PATCH 1/1] IPv6: Fixed support for blackhole and prohibit routes
Could you review ?
Thanks, Kamala
On Fri, Nov 15, 2013 at 7:18 PM, Hannes Frederic Sowa <hannes@stressinduktion.org> wrote: > Hi! > > On Fri, Nov 15, 2013 at 03:06:28PM +0530, Kamala R wrote: >> That's right. We don't show the error for IPv4 routes as it follows a >> different path in kernel while dumping the information as compared >> with IPv6. Therefore, "ip route show" does not show an error while "ip >> -6 route show" does. So it looks to me that this a kernel problem >> which needs to be fixed for consistent behavior. The simplest way to >> fix this seems to be to set the error to zero while dumping the >> information in the v6 path. I have tested this solution and found that >> it works fine. Do you think this is the way to go ? > > If I understand you correctly you propose to drop the output of the error > attribute for IPv6 routes too? It is not that important that those two > outputs are identical and if you make a change, please introduce the > error propagation for IPv4 so one can see the socket errors for those > routes, too. I wouldn't drop those for IPv6 just for consistency reasons. > > Greetings, > > Hannes >
| |