Messages in this thread | | | Date | Tue, 19 Nov 2013 20:22:48 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH] x86: make DR6_RESERVED/DR_CONTROL_RESERVED unsigned long |
| |
On 11/19, Oleg Nesterov wrote: > > DR6_RESERVED and DR_CONTROL_RESERVED are used to clear the unwanted > bits in the "unsigned long" data, but "ulong &= ~int" also clears the > upper bits that are not specified in mask. > > This is actually fine, dr6[32:63] are reserved, but this is not clear > so it would be better to make them "unsigned long" to cleanup the code. > > However, depending on sizeof(long), DR6_RESERVED should be either > 0xFFFF0FF0 or 0xFFFFFFFF_FFFF0FF0, so this patch redefines them as > (~ 32_bit_mask UL) to avoid ifdef's.
Peter, iirc you acked this patch, but its seems it was lost.
Oleg.
| |