Messages in this thread | | | Subject | Re: [PATCH v2] power: Replace printks with dev_* and pr_* routines | From | Joe Perches <> | Date | Tue, 19 Nov 2013 10:53:25 -0800 |
| |
On Tue, 2013-11-19 at 11:46 -0700, Shuah Khan wrote: > Replaced printks with dev_* and pr_* routines. Replacing printk in > __suspend_report_result() will require passing in struct device * > pointer from calling routines and this will require changes to > external interface suspend_report_result() which is used by several > drivers. Hence, this one instance is replaced by pr_err(). [] > diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c [] > @@ -1308,9 +1308,8 @@ int dpm_prepare(pm_message_t state) > error = 0; > continue; > } > - printk(KERN_INFO "PM: Device %s not prepared " > - "for power transition: code %d\n", > - dev_name(dev), error); > + dev_info("PM: not prepared for power transition: ", > + "code %d\n", error);
Shuah, you have to make sure the files modified by your patches compile successfully before sending patches like this.
| |