Messages in this thread | | | Date | Tue, 19 Nov 2013 10:40:53 -0800 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 9/9] staging/lustre/ldlm: fix resource/fid check, use DLDLMRES |
| |
On Tue, Nov 19, 2013 at 09:23:48PM +0800, Peng Tao wrote: > From: Andreas Dilger <andreas.dilger@intel.com> > > In ll_md_blocking_ast() the FID/resource comparison is incorrectly > checking for fid_ver() stored in res_id.name[2] instead of name[1] > changed since http://review.whamcloud.com/2271 (commit 4f91d5161d00) > landed. This does not impact current clients, since name[2] and > fid_ver() are always zero, but it could cause problems in the future. > > In ldlm_cli_enqueue_fini() use ldlm_res_eq() instead of comparing > each of the resource fields separately. > > Use DLDLMRES/PLDLMRES when printing resource names everywhere.
There are codingstyle warnings in this patch, please fix before resending.
greg k-h
| |