Messages in this thread | | | Subject | Re: [Xen-devel] [PATCH v2 1/2] xen: vnuma support for PV guests running as domU | From | Dario Faggioli <> | Date | Tue, 19 Nov 2013 08:15:30 +0100 |
| |
On lun, 2013-11-18 at 15:25 -0500, Elena Ufimtseva wrote: > Signed-off-by: Elena Ufimtseva <ufimtseva@gmail.com>
> diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile > index 96ab2c0..de9deab 100644 > --- a/arch/x86/xen/Makefile > +++ b/arch/x86/xen/Makefile > @@ -13,7 +13,7 @@ CFLAGS_mmu.o := $(nostackp) > obj-y := enlighten.o setup.o multicalls.o mmu.o irq.o \ > time.o xen-asm.o xen-asm_$(BITS).o \ > grant-table.o suspend.o platform-pci-unplug.o \ > - p2m.o > + p2m.o vnuma.o > > obj-$(CONFIG_EVENT_TRACING) += trace.o
I think David said something about this during last round (going fetchin'-cuttin'-pastin' it):
" obj-$(CONFIG_NUMA) += vnuma.o
Then you can remove the #ifdef CONFIG_NUMA from xen/vnuma.c "
> diff --git a/arch/x86/xen/vnuma.c b/arch/x86/xen/vnuma.c
> +/* > + * Called from numa_init if numa_off = 0; ^ if numa_off = 1 ?
> + * we set numa_off = 0 if xen_vnuma_supported() > + * returns true and its a domU; > + */ > +int __init xen_numa_init(void) > +{
> + if (nr_nodes > num_possible_cpus()) { > + pr_debug("vNUMA: Node without cpu is not supported in this version.\n"); > + goto out; > + } > + This is a super-minor thing, but I wouldn't say "in this version". It makes people think that there will be a later version where that will be supported, which we don't know. :-)
> + /* > + * Set a dummy node and return success. This prevents calling any > + * hardware-specific initializers which do not work in a PV guest. > + * Taken from dummy_numa_init code. > + */ > This is a lot better... Thanks! :-)
Regards, Dario
-- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[unhandled content-type:application/pgp-signature] | |