Messages in this thread | | | Date | Tue, 19 Nov 2013 17:51:18 +0100 | From | Javier Martinez Canillas <> | Subject | Re: [RFC 01/23] gpio/omap: raw read and write endian fix |
| |
On 11/19/2013 10:29 AM, Linus Walleij wrote: > On Sat, Nov 16, 2013 at 1:01 AM, Taras Kondratiuk > <taras.kondratiuk@linaro.org> wrote: > >> From: Victor Kamensky <victor.kamensky@linaro.org> >> >> All OMAP IP blocks expect LE data, but CPU may operate in BE mode. >> Need to use endian neutral functions to read/write h/w registers. >> I.e instead of __raw_read[lw] and __raw_write[lw] functions code >> need to use read[lw]_relaxed and write[lw]_relaxed functions. >> If the first simply reads/writes register, the second will byteswap >> it if host operates in BE mode. >> >> Changes are trivial sed like replacement of __raw_xxx functions >> with xxx_relaxed variant. >> >> Signed-off-by: Victor Kamensky <victor.kamensky@linaro.org> >> Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org> > > Since I generally just dislike __raw accessors I went and applied > this. If it collides with any of Tony's fixup work I might need to > take the patch out again, no big deal. > > Some ACKs would be nice, but unless there are major objections > this stays merged.
Looks good to me and also I've tested this patch on a TI DM3730 (Cortex A-8) board in LE mode and found no regressions on devices using a GPIO.
Tested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> > Yours, > Linus Walleij >
Thanks a lot and best regards, Javier
| |