lkml.org 
[lkml]   [2013]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH/RFC] wait_for_completion_timeout() considered harmful.

* Jonathan Corbet <corbet@lwn.net> wrote:

> On Tue, 19 Nov 2013 00:42:09 +0100
> Peter Zijlstra <peterz@infradead.org> wrote:
>
> > I briefly talked to Thomas about this earlier today and we need to
> > fix this at a lower level -- the quick 'n dirty solution is to add
> > 1 jiffy down in the timer-wheel when we enqueue these things.
>
> That can lead to situations like the one I encountered years ago
> where msleep(1) would snooze for 20ms. I didn't get much love for
> my idea of switching msleep() to hrtimers back then, but I still
> think it might be be better to provide the resolution that the
> interface appears to promise.

That looks like a sensible approach - mind resending that patch? We
can put it into the timer tree and see what happens.

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-11-19 08:41    [W:0.069 / U:0.764 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site