[lkml]   [2013]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] x86: boot: Fix mixed indentation in a20.c
On Tue, Nov 19, 2013 at 08:22:41AM +0100, Ingo Molnar wrote:
> * H. Peter Anvin <> wrote:
> > On 11/18/2013 09:50 AM, Johannes Löthberg wrote:
> > > Replace all mixed indentation with tabs
> > >
> > > Signed-off-by: Johannes Löthberg <>
> >
> > NAK. Not worth the churn in the absence of other changes.
> Yes.
> If a20.c was cleaned up altogether, that might be a more tempting
> change, it has a good number of inconsistencies and improving it all
> would make it more readable.
> But it makes little sense to do an incomplete cleanup.

Yeah, senseless cleanup without any benefit whatsoever (yeah, fuck
readability! :-)) should be forbidden, if you ask me. Especially
since it dilutes and muds up git history and finding the patch which
introduced a change turns into a serious undertaking.


Sent from a fat crate under my desk. Formatting is fine.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2013-11-19 12:21    [W:0.100 / U:2.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site