Messages in this thread Patch in this message |  | | From | Thierry Reding <> | Subject | [PATCH 2/3] mfd: cros ec: spi: Increase EC transaction delay | Date | Mon, 18 Nov 2013 11:30:48 +0100 |
| |
From: Derek Basehore <dbasehore@chromium.org>
50 us is not a long enough delay between EC transactions. At least 70 us are needed for the 16 MHz STM32L part. Increase the delay to 200 us for an extra safety margin.
Signed-off-by: Derek Basehore <dbasehore@chromium.org> Reviewed-by: Randall Spangler <rspangler@chromium.org> Signed-off-by: Thierry Reding <treding@nvidia.com> --- drivers/mfd/cros_ec_spi.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c index d05349a7381e..af5c2f6601cf 100644 --- a/drivers/mfd/cros_ec_spi.c +++ b/drivers/mfd/cros_ec_spi.c @@ -51,10 +51,11 @@ /* * Time between raising the SPI chip select (for the end of a * transaction) and dropping it again (for the next transaction). - * If we go too fast, the EC will miss the transaction. It seems - * that 50us is enough with the 16MHz STM32 EC. + * If we go too fast, the EC will miss the transaction. We know that we + * need at least 70 us with the 16 MHz STM32 EC, so go with 200 us to be + * safe. */ -#define EC_SPI_RECOVERY_TIME_NS (50 * 1000) +#define EC_SPI_RECOVERY_TIME_NS (200 * 1000) /** * struct cros_ec_spi - information about a SPI-connected EC -- 1.8.4.2
|  |