Messages in this thread | | | Date | Mon, 18 Nov 2013 19:33:18 +0900 | From | Alex Courbot <> | Subject | Re: [PATCH v2] Documentation: gpiolib: document new interface |
| |
On 11/18/2013 06:34 PM, Linus Walleij wrote: > On Sat, Nov 16, 2013 at 1:34 PM, Alexandre Courbot <acourbot@nvidia.com> wrote: > >> The first version received zero feedback, hopefully this one will get more >> attention. :) Not much changes, just some more proofreading and the fixes >> and improvements that came from it. It looks ok as far as I am concerned. > > Sorry I was swamped with other stuff... > >> Linus, I hope this can be merged during the -rc cycle of 3.13, since the >> gpiod_ interface is going to be introduced there. It would not make much >> sense for it to come without its documentation. > > You're right of course. I'll read through it and apply fixes on top > (or squash into your patch.)
Great, thanks!
> Formal stuff: > Don't we need an 00-INDEX file? > (Maybe Rob can tell whether this is desirable.)
Good idea. gpio.txt somehow fulfills that role, but it might be better if we split it. Would you like me to submit a new revision?
> I don't like double spaces after periods. I will just go and remove > all of them from the new documentation unless you convince me > otherwise. Reference: > https://en.wikipedia.org/wiki/Sentence_spacing
Please do - actually I started doing it (they come from the old documentation, not the bits I have written myself) but have obviously missed at least a few of them. :)
Thanks, Alex.
| |