Messages in this thread |  | | Date | Tue, 19 Nov 2013 09:54:58 +0800 | From | Yijing Wang <> | Subject | Re: [3.11.4] Thunderbolt/PCI unplug oops in pci_pme_list_scan |
| |
> The pcie_portdrv .probe() method calls pci_enable_device() once, in > pcie_port_device_register(), but the .remove() method calls > pci_disable_device() twice, in pcie_port_device_remove() and in > pcie_portdrv_remove(). > > That causes a "disabling already-disabled device" warning when removing a > PCIe port device. This happens all the time when removing Thunderbolt > devices, but is also easy to reproduce with, e.g., > "echo 0000:00:1c.3 > /sys/bus/pci/drivers/pcieport/unbind" > > This patch removes the disable from pcie_portdrv_remove(). > > [bhelgaas: changelog, tag for stable] > Reported-by: David Bulkow <David.Bulkow@stratus.com> > Reported-by: Mika Westerberg <mika.westerberg@linux.intel.com> > Signed-off-by: Yinghai Lu <yinghai@kernel.org> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > CC: stable@vger.kernel.org # v2.6.32+
Hi Bjorn, This issue in X86 seems to be introduced after commit 928bea9 "PCI: Delay enabling bridges until they're needed" So this patch needs to back port to 2.6.32+ ?
> --- > drivers/pci/pcie/portdrv_pci.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c > index cd1e57e51aa7..0d8fdc48e642 100644 > --- a/drivers/pci/pcie/portdrv_pci.c > +++ b/drivers/pci/pcie/portdrv_pci.c > @@ -223,7 +223,6 @@ static int pcie_portdrv_probe(struct pci_dev *dev, > static void pcie_portdrv_remove(struct pci_dev *dev) > { > pcie_port_device_remove(dev); > - pci_disable_device(dev); > } > > static int error_detected_iter(struct device *device, void *data) > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > > . >
-- Thanks! Yijing
|  |