lkml.org 
[lkml]   [2013]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 3/8] perf symbol: Save vmlinux or kallsyms path loaded
Date
Save vmlinux or kallsyms path loaded using embedded default lookup (ie.,
not a user specified path). Upcoming perf sched timehist command requires
kernel symbols for properly computing idle times and prints a warning
if the kernel symbols are not loaded.

Signed-off-by: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
---
tools/perf/util/symbol.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index f55c18da1e40..915eb6c4a248 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -1437,6 +1437,8 @@ int dso__load_vmlinux(struct dso *dso, struct map *map,
dso->data_type = DSO_BINARY_TYPE__VMLINUX;
dso__set_long_name(dso, (char *)vmlinux);
dso__set_loaded(dso, map->type);
+ if (symbol_conf.vmlinux_name == NULL)
+ symbol_conf.vmlinux_name = strdup(symfs_vmlinux);
pr_debug("Using %s for symbols\n", symfs_vmlinux);
}

@@ -1629,8 +1631,11 @@ static int dso__load_kernel_sym(struct dso *dso, struct map *map,

do_kallsyms:
err = dso__load_kallsyms(dso, kallsyms_filename, map, filter);
- if (err > 0)
+ if (err > 0) {
+ if (symbol_conf.kallsyms_name == NULL)
+ symbol_conf.kallsyms_name = strdup(kallsyms_filename);
pr_debug("Using %s for symbols\n", kallsyms_filename);
+ }
free(kallsyms_allocated_filename);

if (err > 0 && !dso__is_kcore(dso)) {
--
1.8.3.4 (Apple Git-47)


\
 
 \ /
  Last update: 2013-11-19 02:41    [W:0.131 / U:0.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site