Messages in this thread |  | | From | "Rafael J. Wysocki" <> | Subject | Re: [PULL REQUEST] i2c for 3.13 | Date | Tue, 19 Nov 2013 01:11:25 +0100 |
| |
On Monday, November 18, 2013 03:46:34 PM Linus Torvalds wrote: > On Mon, Nov 18, 2013 at 11:38 AM, Wolfram Sang <wsa@the-dreams.de> wrote: > > > > here is the pull request from the i2c subsystem for 3.13: > > So while resolving some fairly trivial conflicts here, I noticed that > commit a76e9bd89ae7 ("i2c: attach/detach I2C client device to the ACPI > power domain") that I got earlier through the ACPI/PM tree calls > acpi_dev_pm_detach() even when the device "->remove()" function fails. > But it only sets clientdata to NULL if it succeeds. > > That looks a bit odd. > > I didn't try to fix it, though. I just thought I'd point out the oddity.
Well, given that the driver core doesn't even check the return value of dev->bus->remove(dev), I think doing the unconditional acpi_dev_pm_detach() is actually correct and clientdata should be cleared unconditionally too.
Rafael
|  |