[lkml]   [2013]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PULL REQUEST] i2c for 3.13
On Monday, November 18, 2013 03:46:34 PM Linus Torvalds wrote:
> On Mon, Nov 18, 2013 at 11:38 AM, Wolfram Sang <> wrote:
> >
> > here is the pull request from the i2c subsystem for 3.13:
> So while resolving some fairly trivial conflicts here, I noticed that
> commit a76e9bd89ae7 ("i2c: attach/detach I2C client device to the ACPI
> power domain") that I got earlier through the ACPI/PM tree calls
> acpi_dev_pm_detach() even when the device "->remove()" function fails.
> But it only sets clientdata to NULL if it succeeds.
> That looks a bit odd.
> I didn't try to fix it, though. I just thought I'd point out the oddity.

Well, given that the driver core doesn't even check the return value of
dev->bus->remove(dev), I think doing the unconditional acpi_dev_pm_detach()
is actually correct and clientdata should be cleared unconditionally too.


 \ /
  Last update: 2013-11-19 01:41    [W:0.042 / U:5.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site