Messages in this thread Patch in this message |  | | Subject | [PATCH] checkpatch.pl: Check for function declarations without arguments | From | Joe Perches <> | Date | Mon, 18 Nov 2013 15:23:01 -0800 |
| |
Functions like this one are evil:
void foo() { ... }
Because these functions allow variadic arguments without checking the arguments at all. Original-patch-by: Richard Weinberger <richard@nod.at> Signed-off-by: Joe Perches <joe@perches.com> --- scripts/checkpatch.pl | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 61090e0..2e1ff0c 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2634,6 +2634,15 @@ sub process { $herecurr); } +# check for function declarations without arguments like "int foo()" + if ($line =~ /(\b$Type\s+$Ident)\s*\(\s*\)/) { + if (ERROR("FUNCTION_WITHOUT_ARGS", + "Bad function definition - $1() should probably be $1(void)\n" . $herecurr) && + $fix) { + $fixed[$linenr - 1] =~ s/(\b($Type)\s+($Ident))\s*\(\s*\)/$2 $3(void)/; + } + } + # check for declarations of struct pci_device_id if ($line =~ /\bstruct\s+pci_device_id\s+\w+\s*\[\s*\]\s*\=\s*\{/) { WARN("DEFINE_PCI_DEVICE_TABLE",
|  |