Messages in this thread Patch in this message |  | | From | Richard Weinberger <> | Subject | [PATCH] checkpatch.pl: Check for functions without a real prototype | Date | Mon, 18 Nov 2013 23:31:54 +0100 |
| |
Functions like this one are evil:
void foo() { ... }
Signed-off-by: Richard Weinberger <richard@nod.at> CC: hpa@zytor.com --- scripts/checkpatch.pl | 13 +++++++++++++ 1 file changed, 13 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 61090e0..a1b846d 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2785,6 +2785,19 @@ sub process { "open brace '{' following function declarations go on the next line\n" . $herecurr); } + if ($line=~/$Type\s*$Ident\(\)/) { + ERROR("FUNCTION_NO_PROTOTYPE", +"Function without a real prototype\n" . $herecurr . +"Thou shalt not, in the language of C, under any circumstances, on the +pain of death, declare or define a function with an empty set of +parentheses, for though in the language of C++ it meaneth the same as +(void), in C it meaneth (...) which is of meaningless as there be no +anchor argument by which the types of the varadic arguments can be +expressed, and which misleadeth the compiler into allowing unsavory code +and in some cases generate really ugly stuff for varadic handling. + -hpa\n"); + } + # open braces for enum, union and struct go on the same line. if ($line =~ /^.\s*{/ && $prevline =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?\s*$/) { -- 1.8.4.2
|  |