Messages in this thread |  | | Date | Mon, 18 Nov 2013 12:30:28 -0700 | From | Jens Axboe <> | Subject | Re: [PATCH] bio: fix argument of __bio_add_page() for max_sectors > 0xffff |
| |
On 11/18/2013 06:11 AM, Akinobu Mita wrote: > The data type of max_sectors and max_hw_sectors in queue settings are > unsigned int. But these values are passed to __bio_add_page() as an > argument whose data type is unsigned short. In the worst case such as > max_sectors is 0x10000, bio_add_page() can't add a page and IOs can't > proceed.
Thanks, added. Even at 512b sectors, 0xffff sectors would be a huuuuge page. So I don't think we'd ever see this bug hit, iirc huge pages are still broken down for IO. But it's better to be safe... -- Jens Axboe
|  |