lkml.org 
[lkml]   [2013]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PROBLEM] possible divide by 0 in kernel/sched/cputime.c scale_stime()

* Peter Zijlstra <peterz@infradead.org> wrote:

> I would be tempted to say you should simply mark the tsc unstable on
> boot and live with that -- we fully assume the sched_clock stuff is
> not going backwards in an 'observable' way.

BIOS crap and actual hardware bugs do happen - so kernel code needs to
consider TSC input with a pinch of salt, assuming that it's untrusted
external data.

> That said, it might be nice to not crash either..

Indeed, not crashing on weird TSC input is absolutely required!

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-11-18 17:21    [W:0.520 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site