Messages in this thread |  | | Date | Mon, 18 Nov 2013 14:45:12 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 02/10] mtd: st_spi_fsm: Supply all register address and bit logic defines |
| |
On Mon, Nov 18, 2013 at 02:24:47PM +0000, Lee Jones wrote:
> For example, we have thought about inserting a layer which handles the > type of communication that'll be utilised i.e. true SPI, or our > bespoke FSM implementation for instance. This would enable us to issue > serial_flash_write(), serial_flash_write_then_read(), ... in the m25p80 > driver and not care which protocol is used. However, in reality this > won't really save a great deal of code - not in our case at least.
Right, that's what I'm suggesting. It's not so much for the code saving as for the data saving, allowing device trees that just say "flash chip X is connected" rather than requiring either the flash chip information in multiple places in the kernel or (worse) have the commands added to the DTs of individual boards using the flash chip. [unhandled content-type:application/pgp-signature] |  |