Messages in this thread |  | | Date | Mon, 18 Nov 2013 14:31:35 +0000 | From | Andy Whitcroft <> | Subject | Re: [PATCH] checkpatch: Fix "Use of uninitialized value" warnings |
| |
On Mon, Nov 18, 2013 at 05:51:04AM -0800, Joe Perches wrote: > checkpatch is currently confused about some complex macros > and references undefined variables $stat and $cond. > > Make sure these are defined before using them. > > Signed-off-by: Joe Perches <joe@perches.com> > --- > scripts/checkpatch.pl | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 61090e0..9c981003 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -3289,6 +3289,7 @@ sub process { > } > } > if (!defined $suppress_whiletrailers{$linenr} && > + defined($stat) && defined($cond) && > $line =~ /\b(?:if|while|for)\s*\(/ && $line !~ /^.\s*#/) { > my ($s, $c) = ($stat, $cond);
Seems reasonable indeed.
Acked-by: Andy Whitcroft <apw@canonical.com>
-apw
|  |