lkml.org 
[lkml]   [2013]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 02/10] mtd: st_spi_fsm: Supply all register address and bit logic defines
    On Mon, Nov 18, 2013 at 09:32:29AM +0000, Lee Jones wrote:

    > I've actually travelled down the route of separating the SPI
    > Controller parts to drivers/spi. It's possible to do that and perhaps
    > we could then use the generic m25p80 Serial Flash driver as the
    > back-end, but it would be incredibly complicated and would mean we'd
    > need to duplicate almost all of the m25p80 driver into the SPI
    > Controller. The Falcon SPI driver tried to do something similar, but
    > now looks broken due to some incompatible changes in m25p80. We also
    > want to avoid putting ourselves in that position of fragility.

    What I've said to people doing similar drivers before is that it seems
    like there should be an abstraction added in the MTD framework for SPI
    flash controllers like this is that if there is genunie flash-specific
    stuff going on then the mp25p80 driver ought to be split so that the
    code that understands what commands to send to the flash chip is split
    out from the code that actually sends those commands to the chip. The
    existing SPI support would then be a function driver for this. This
    would mean we don't need to support the flash chips multiple times.
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2013-11-18 15:01    [W:5.018 / U:1.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site