Messages in this thread Patch in this message |  | | From | Caizhiyong <> | Subject | [PATCH] regmap: Fix 'ret' would return an uninitialized value | Date | Mon, 18 Nov 2013 12:29:02 +0000 |
| |
From: Cai Zhiyong <caizhiyong@huawei.com> Date: Mon, 18 Nov 2013 20:21:49 +0800 Subject: [PATCH] regmap: Fix 'ret' would return an uninitialized value
This patch give a warning when calling regmap_register_patch with parameter num_regs <= 0.
When the num_regs parameter is zero and krealloc doesn't fail, then the code would return an uninitialized value. However, calling this function with num_regs == 0, would be a waste as it essentially does nothing.
Signed-off-by: Cai Zhiyong <caizhiyong@huawei.com> --- drivers/base/regmap/regmap.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index 9c021d9..9a36ac1 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c @@ -2173,6 +2173,10 @@ int regmap_register_patch(struct regmap *map, const struct reg_default *regs, int i, ret; bool bypass; + if (WARN_ONCE(num_regs <= 0, "invalid registers number (%d)\n", + num_regs)) + return 0; + map->lock(map->lock_arg); bypass = map->cache_bypass; -- 1.8.1.5
|  |