lkml.org 
[lkml]   [2013]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] brcmsmac: Fix build dep on LEDS_CLASS
From
2013/11/17 Arend van Spriel <arend@broadcom.com>:
> On 11/17/13 14:37, Borislav Petkov wrote:
>>
>> From: Borislav Petkov<bp@suse.de>
>>
>> When building randconfigs with CONFIG_BCMA_DRIVER_GPIO=y, I get
>>
>> drivers/built-in.o: In function `brcms_led_unregister':
>> (.text+0x351aca): undefined reference to `led_classdev_unregister'
>> drivers/built-in.o: In function `brcms_led_register':
>> (.text+0x351c65): undefined reference to `led_classdev_register'
>>
>> during the final linking stage because brcmsmac/led.c needs LEDS_CLASS
>> for reg/dereg. Fix that.
>
>
> Wouldn't it be better to fix it in brcmsmac.

I agree. After all bcma doesn't use/register LEDs, so this should be
placed in drivers that do.

P.S.
Borislav: I think I didn't get your original patch.


\
 
 \ /
  Last update: 2013-11-18 13:21    [W:1.008 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site