lkml.org 
[lkml]   [2013]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] I2C: busses: i2c-eg20t Do not print error message in syslog if no ACK received
On Sun, Nov 17, 2013 at 01:18:09PM +0100, Wolfram Sang wrote:
>
> > Is there another reason why pch_i2c_getack returned EPROTO?
> > May be ENXIO was introduced later?
>
> Imperfect review :)
>
> > I think we can just replace the -EIO with -ENXIO or do you want to pick up the return
> > vale of pch_i2c_getack and return that ?
>
> The latter. As a rule of thumb, it is usually more sustainable to pass
> through error codes. Overloading them should only be done when really
> necessary IMO.
>
Ok, if that will be ok in pch_i2c_wait_for_check_xfer i will resend
the patch.

ret = pch_i2c_getack(adap);

if (ret)
pch_dbg(adap, "Receive NACK for slave address setting\n");

return (int)ret;

Regards
Andy


\
 
 \ /
  Last update: 2013-11-17 18:21    [W:0.041 / U:0.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site