Messages in this thread | | | Date | Sun, 17 Nov 2013 13:18:09 +0100 | From | Wolfram Sang <> | Subject | Re: [PATCH v2] I2C: busses: i2c-eg20t Do not print error message in syslog if no ACK received |
| |
> Is there another reason why pch_i2c_getack returned EPROTO? > May be ENXIO was introduced later?
Imperfect review :)
> I think we can just replace the -EIO with -ENXIO or do you want to pick up the return > vale of pch_i2c_getack and return that ?
The latter. As a rule of thumb, it is usually more sustainable to pass through error codes. Overloading them should only be done when really necessary IMO.
[unhandled content-type:application/pgp-signature]
| |