Messages in this thread | | | Date | Sun, 17 Nov 2013 20:45:23 -0800 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] sysfs: use a separate locking class for open files depending on mmap |
| |
On Sun, Nov 17, 2013 at 12:29:37PM +0900, Tejun Heo wrote: > On Sat, Nov 16, 2013 at 10:21:19PM -0500, Dave Jones wrote: > > On Sun, Nov 17, 2013 at 11:17:36AM +0900, Tejun Heo wrote: > > > > > > > + if (has_mmap) > > > + mutex_init(&of->mutex); > > > + else > > > + mutex_init(&of->mutex); > > > > ummm... > > Supposed to look that way. It'll give two separate static lock class > keys to of->mutex. Yeah, looks weird. Any better ideas?
Doesn't gcc optimize that away to just one lock class anyway?
greg k-h
| |