Messages in this thread | | | Date | Mon, 18 Nov 2013 14:04:17 +1100 | From | Stephen Rothwell <> | Subject | Re: [PATCH 2/2] mm: create a separate slab for page->ptl allocation |
| |
Hi Geert,
On Sat, 16 Nov 2013 21:43:32 +0100 Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Thu, Nov 7, 2013 at 3:14 PM, Kirill A. Shutemov > <kirill.shutemov@linux.intel.com> wrote: > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > > +static inline void pgtable_init(void) > > +{ > > + ptlock_cache_init(); > > + pgtable_cache_init(); > > +} > > sparc64defconfig: > > include/linux/mm.h:1391:2: error: implicit declaration of function > 'pgtable_cache_init' [-Werror=implicit-function-declaration] > arch/sparc/include/asm/pgtable_64.h:978:13: error: conflicting types > for 'pgtable_cache_init' [-Werror] > > http://kisskb.ellerman.id.au/kisskb/buildresult/10040274/ > > Has this been in -next?
No, it hasn't :-(
> Probably it needs <asm/pgtable.h>.
Actually it is because on sparc64, asm/tlbflush_64.h includes linux/mm.h (and asm/pgtable.h -> asm/pgtable_64.h -> asm/tlbflush.h -> asm/tlbflush_64.h)
(see my other error report and I have reverted that commit from linux-next today.)
-- Cheers, Stephen Rothwell sfr@canb.auug.org.au [unhandled content-type:application/pgp-signature] | |