lkml.org 
[lkml]   [2013]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] jffs2: fix sparse errors: directive in argument list
From
On Sun, Nov 17, 2013 at 11:45 PM, Joe Perches <joe@perches.com> wrote:
> On Sun, 2013-11-17 at 20:34 -0200, Erico Nunes wrote:
>> Do you mean it as an error in the sparse tool?
>
> Yes. I think it's a defect in how sparse
> treats string concatenation.
>
> That style:
>
> printk("%s\n",
> #ifdef FOO
> "foo"
> #endif
> #ifdef BAR
> "bar"
> #endif
> "string");
>
> is pretty common in the kernel sources.
>
> The patch itself is otherwise fine, but
> perhaps unnecessary.

I agree with Joe, the patch fixes a non-issue.

--
Thanks,
//richard


\
 
 \ /
  Last update: 2013-11-18 00:21    [W:0.065 / U:0.720 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site