Messages in this thread | | | Date | Sun, 17 Nov 2013 23:53:16 +0100 | Subject | Re: [PATCH] jffs2: fix sparse errors: directive in argument list | From | Richard Weinberger <> |
| |
On Sun, Nov 17, 2013 at 11:45 PM, Joe Perches <joe@perches.com> wrote: > On Sun, 2013-11-17 at 20:34 -0200, Erico Nunes wrote: >> Do you mean it as an error in the sparse tool? > > Yes. I think it's a defect in how sparse > treats string concatenation. > > That style: > > printk("%s\n", > #ifdef FOO > "foo" > #endif > #ifdef BAR > "bar" > #endif > "string"); > > is pretty common in the kernel sources. > > The patch itself is otherwise fine, but > perhaps unnecessary.
I agree with Joe, the patch fixes a non-issue.
-- Thanks, //richard
| |