Messages in this thread |  | | Date | Sun, 17 Nov 2013 19:28:52 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 4/5 v2] input: tc3589x-keypad: support probing from device tree |
| |
> > Thus I guess we should not use the name, which has the most adopters > > in kernel (or out of kernel). Instead the most fitting name should > > be used. Current suggestions (taken from kernel) are: > > > > * <<vendor>>,no-autorepeat > > * keypad,autorepeat > > * linux,keypad-no-autorepeat > > * linux,input-no-autorepeat > > * linux,no-autorepeat > > * autorepeat > > > > I do not really care, which one is chosen, except for two things: > > > > * <<vendor>> seems wrong. This is not vendor specific. > > * I would prefer "input-" over "keypad-", since then the same name > > can be used for single keys, buttons, etc. > > Both of those sound valid to me, but I think it may make sense to keep > the "linux," prefix. As I understand it this is really telling the Linux > input subsystem to react to a device acting in a certain way, rather > than describing or configuring the device in a certain way.
I'd say it is very much configuring device in certain way, and yes, other operating systems will want to do autorepeat, too.
I believe we don't want to end up with
linux,input-no-autorepeat bsd,keypad-autorepeat windows-phone,disable-autorepeat
...and should avoid linux, prefix. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
|  |