Messages in this thread | | | Date | Sat, 16 Nov 2013 10:54:46 +0530 | From | viresh kumar <> | Subject | Re: [Update PATCH 1/1] Cpufreq: Make governor data on nonboot cpus across system suspend/resume |
| |
On Friday 15 November 2013 04:24 PM, Viresh Kumar wrote: > Though the patch I have sent fixes a problem similar to this but I don't think > patch of any of us will solve the issue Rainer is facing.. > > I checked his system configuration and its like this: > - Four CPUs, all having separate clock domains (atleast from kernel > perspective) and so separate policy structure. > - All are using ondemand governor > - not using CPUFREQ_HAVE_GOVERNOR_PER_POLICY feature > - So there is a single set of tunables for ondemand governor that is applicable > across all CPUs.. > > The way INIT/EXIT are designed in cpufreq_governor.c should take care > of this scenario. > > memory for tunables must not be freed unless all the CPUs are removed. > Which can't happen, as we only offline non-boot CPUs and so I believe > that memory isn't getting freed and so your solution wouldn't address his > problem.. > > Sorry if I said something stupid enough :)
I haven't :)
From your another mail it is clear that you have used separate governors and so you have faced the real problem :)
Hope my patch fixes it for you.
| |