lkml.org 
[lkml]   [2013]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH net v3 4/4] r8152: fix incorrect type in assignment
    Date
    The data from the hardware should be little endian. Correct the
    declaration.

    Signed-off-by: Hayes Wang <hayeswang@realtek.com>
    ---
    drivers/net/usb/r8152.c | 18 +++++++++---------
    1 file changed, 9 insertions(+), 9 deletions(-)

    diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
    index 81a4171..25e8fa8 100644
    --- a/drivers/net/usb/r8152.c
    +++ b/drivers/net/usb/r8152.c
    @@ -307,22 +307,22 @@ enum rtl8152_flags {
    #define MCU_TYPE_USB 0x0000

    struct rx_desc {
    - u32 opts1;
    + __le32 opts1;
    #define RX_LEN_MASK 0x7fff
    - u32 opts2;
    - u32 opts3;
    - u32 opts4;
    - u32 opts5;
    - u32 opts6;
    + __le32 opts2;
    + __le32 opts3;
    + __le32 opts4;
    + __le32 opts5;
    + __le32 opts6;
    };

    struct tx_desc {
    - u32 opts1;
    + __le32 opts1;
    #define TX_FS (1 << 31) /* First segment of a packet */
    #define TX_LS (1 << 30) /* Final segment of a packet */
    #define TX_LEN_MASK 0x3ffff

    - u32 opts2;
    + __le32 opts2;
    #define UDP_CS (1 << 31) /* Calculate UDP/IP checksum */
    #define TCP_CS (1 << 30) /* Calculate TCP/IP checksum */
    #define IPV4_CS (1 << 29) /* Calculate IPv4 checksum */
    @@ -877,7 +877,7 @@ static void write_bulk_callback(struct urb *urb)
    static void intr_callback(struct urb *urb)
    {
    struct r8152 *tp;
    - __u16 *d;
    + __le16 *d;
    int status = urb->status;
    int res;

    --
    1.8.3.1


    \
     
     \ /
      Last update: 2013-11-15 09:41    [W:2.797 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site