lkml.org 
[lkml]   [2013]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH tip/core/rcu 14/28] rcutorture: Eliminate --rcu-kvm argument
Date
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>

The --rcu-kvm argument was intended to allow the scripts to live in
an alternate location. Unfortunately, this prevents the kvm.sh script
from using common functions until after it finished parsing arguments,
because it doesn't know where to find them until then. However, "cp -a"
and "ln -s" work pretty well, so lack of an --rcu-kvm argument can be
easily worked around.

This commit therefore removes this argument.

Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Greg KH <gregkh@linuxfoundation.org>
---
tools/testing/selftests/rcutorture/bin/kvm.sh | 15 +--------------
1 file changed, 1 insertion(+), 14 deletions(-)

diff --git a/tools/testing/selftests/rcutorture/bin/kvm.sh b/tools/testing/selftests/rcutorture/bin/kvm.sh
index 89164c245ca1..2af549491f23 100644
--- a/tools/testing/selftests/rcutorture/bin/kvm.sh
+++ b/tools/testing/selftests/rcutorture/bin/kvm.sh
@@ -46,7 +46,6 @@ usage () {
echo " --duration minutes"
echo " --kversion vN.NN"
echo " --qemu-cmd qemu-system-..."
- echo " --rcu-kvm absolute-pathname"
echo " --results absolute-pathname"
echo " --relbuilddir relative-pathname"
exit 1
@@ -107,19 +106,6 @@ do
RCU_QEMU_CMD="$2"; export RCU_QEMU_CMD
shift
;;
- --rcu-kvm)
- checkarg --rcu-kvm "(absolute pathname)" "$#" "$2" '^/' error
- KVM=$2; export KVM
- if -z "$gotbuilddir"
- then
- builddir=${KVM}/b1
- fi
- if -n "$gotrelbuilddir"
- then
- builddir=${KVM}/${relbuilddir}
- fi
- shift
- ;;
--relbuilddir)
checkarg --relbuilddir "(relative pathname)" "$#" "$2" '^[^/]*$' '^--'
relbuilddir=$2
@@ -133,6 +119,7 @@ do
shift
;;
*)
+ echo Unknown argument $1
usage
;;
esac
--
1.8.1.5


\
 
 \ /
  Last update: 2013-11-16 03:21    [W:0.139 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site