[lkml]   [2013]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[RFC 14/23] USB: ehci-omap: raw read and write endian fix
From: Victor Kamensky <>

All OMAP IP blocks expect LE data, but CPU may operate in BE mode.
Need to use endian neutral functions to read/write h/w registers.
I.e instead of __raw_read[lw] and __raw_write[lw] functions code
need to use read[lw]_relaxed and write[lw]_relaxed functions.
If the first simply reads/writes register, the second will byteswap
it if host operates in BE mode.

Changes are trivial sed like replacement of __raw_xxx functions
with xxx_relaxed variant.

Signed-off-by: Victor Kamensky <>
Signed-off-by: Taras Kondratiuk <>
drivers/usb/host/ehci-omap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
index 6fa82d6..803e706 100644
--- a/drivers/usb/host/ehci-omap.c
+++ b/drivers/usb/host/ehci-omap.c
@@ -73,12 +73,12 @@ struct omap_hcd {

static inline void ehci_write(void __iomem *base, u32 reg, u32 val)
- __raw_writel(val, base + reg);
+ writel_relaxed(val, base + reg);

static inline u32 ehci_read(void __iomem *base, u32 reg)
- return __raw_readl(base + reg);
+ return readl_relaxed(base + reg);

/* configure so an HC device and id are always provided */

 \ /
  Last update: 2013-11-16 03:01    [W:0.082 / U:1.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site