Messages in this thread | | | Date | Fri, 15 Nov 2013 15:07:45 +0000 | From | Mark Rutland <> | Subject | Re: [PATCH] openrisc: Add DTS and defconfig for DE0-Nano |
| |
On Fri, Nov 15, 2013 at 09:50:18AM +0000, Jonas Bonn wrote: [...]
> > + gpio0: gpio@91000000 { > > + compatible = "opencores,jbtrivial"; > > There's no project called 'jbtrivial' at OpenCores. Should this be > "linux,jbtrivial" to indicate that this refers to a Linux driver?
I would prefer not. Having driver names in bindings is an antipattern; drivers should be free to change independently of the hardware or bindings, and we should be able to create new drivers that handle existing bindings.
Either a new compatible string should be allcoated, or one of the generic bindings should be used. While we do have drivers for the generic cases, the *-generic bindings are treated as a specification that hardware can meet, and are not intended to change. They are also there fore independent of Linux.
Thanks, Mark.
| |