lkml.org 
[lkml]   [2013]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] panic: setup panic_timeout early

* Felipe Contreras <felipe.contreras@gmail.com> wrote:

> On Tue, Nov 12, 2013 at 6:03 PM, Ingo Molnar <mingo@kernel.org> wrote:
> >
> >> +static int __init set_panic_timeout(char *val)
> >> +{
> >> + long timeout;
> >> + int ret;
> >> +
> >> + ret = kstrtol(val, 0, &timeout);
> >> + if (ret < 0)
> >> + return ret;
> >> +
> >> + panic_timeout = timeout;
> >> + return 0;
> >> +}
> >
> > I think the type of the 'timeout' local variable should match the type of
> > 'panic_timeout' (which is 'int', not 'long').
>
> So you would rather have this?
>
> kstrtol(val, 0, (long *)&timeout);
>
> Couldn't that potentially write the value beyond the memory
> allocated to 'timeout'?

No, casting that to 'long *' is actively wrong, I'd use a
string -> integer conversion method that deals with ints,
not longs, such as kstrtoint().

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-11-15 13:01    [W:0.069 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site