Messages in this thread | | | Date | Fri, 15 Nov 2013 12:27:35 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH v2] panic: setup panic_timeout early |
| |
* Felipe Contreras <felipe.contreras@gmail.com> wrote:
> On Tue, Nov 12, 2013 at 6:03 PM, Ingo Molnar <mingo@kernel.org> wrote: > > > >> +static int __init set_panic_timeout(char *val) > >> +{ > >> + long timeout; > >> + int ret; > >> + > >> + ret = kstrtol(val, 0, &timeout); > >> + if (ret < 0) > >> + return ret; > >> + > >> + panic_timeout = timeout; > >> + return 0; > >> +} > > > > I think the type of the 'timeout' local variable should match the type of > > 'panic_timeout' (which is 'int', not 'long'). > > So you would rather have this? > > kstrtol(val, 0, (long *)&timeout); > > Couldn't that potentially write the value beyond the memory > allocated to 'timeout'?
No, casting that to 'long *' is actively wrong, I'd use a string -> integer conversion method that deals with ints, not longs, such as kstrtoint().
Thanks,
Ingo
| |