Messages in this thread | | | From | Peng Tao <> | Date | Fri, 15 Nov 2013 18:26:21 +0800 | Subject | Re: [PATCH 07/40] staging/lustre/hsm: Implementation of exclusive open |
| |
On Fri, Nov 15, 2013 at 12:17 PM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > On Fri, Nov 15, 2013 at 12:13:09AM +0800, Peng Tao wrote: >> From: Jinshan Xiong <jinshan.xiong@intel.com> >> >> In this patch, a framework of lease is implemented. However, >> only exclusive lease is supported right now. > > Which is a problem, why? > > Why do you want to add this new functionality? What is it good for? > Who will use it? > Only brief info for the patch in included in the commit message. The long story is saved in the external link https://jira.hpdd.intel.com/browse/LU-2919. I guess I need to pull more bits to the commit message to make it more understandable.
> Oh, and the patch doesn't apply to my tree, AND it contains a bunch of > foolish coding style errors, so even if I did understand what this was > for, and why we wanted it, I couldn't. > I'll fix up. sorry.
Thanks, Tao
| |