Messages in this thread | | | Subject | Re: [PATCH 4/4] arm64: advertise CPU features for modalias matching | From | "H. Peter Anvin" <> | Date | Thu, 14 Nov 2013 11:05:54 -0800 |
| |
arch/what again?
Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: >On 14 November 2013 16:29, Catalin Marinas <catalin.marinas@arm.com> >wrote: >> On Mon, Nov 11, 2013 at 10:19:35AM +0000, Ard Biesheuvel wrote: >>> +ssize_t arch_print_cpu_modalias(struct device *dev, >>> + struct device_attribute *attr, >>> + char *buf) >>> +{ >>> + unsigned int caps; >>> + ssize_t n; >>> + int i; >>> + >>> + /* >>> + * With 32 features maximum (taking 5 bytes each to print), we >don't >>> + * need to worry about overrunning the PAGE_SIZE sized buffer. >>> + */ >>> + n = sprintf(buf, "cpu:type:arm64:feature:"); >> >> I would use "aarch64" here instead of arm64 for consistency with the >> architecture mode, compiler triplet and ELF_PLATFORM definition in >the >> kernel. > >OK, I will change that. > >Regards, >Ard,
-- Sent from my mobile phone. Please pardon brevity and lack of formatting.
| |