lkml.org 
[lkml]   [2013]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH 9/9] KEYS: Fix encrypted key type update method
Date
Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:

> Is there a keyutils git repo with a version of keyctl that supports the
> control option?

http://git.kernel.org/cgit/linux/kernel/git/dhowells/keyutils.git/log/?h=development

> - type size_t is unsigned, no need to verify that it is negative.

It doesn't hurt either...

> - missing Documentation/security/keys-trusted-encrypted.txt updates

Fixed (see diff below), but I suspect trusted_update() also needs scrutiny.

> - the encrypted_preparse() comment still says 'encrypted_instantiate'

Fixed.

David
---
diff --git a/Documentation/security/keys-trusted-encrypted.txt b/Documentation/security/keys-trusted-encrypted.txt
index e105ae97a4f5..78794adf445d 100644
--- a/Documentation/security/keys-trusted-encrypted.txt
+++ b/Documentation/security/keys-trusted-encrypted.txt
@@ -61,7 +61,7 @@ Usage:
keyctl add encrypted name "new [format] key-type:master-key-name keylen"
ring
keyctl add encrypted name "load hex_blob" ring
- keyctl update keyid "update key-type:master-key-name"
+ keyctl control keyid encrypted change-master-key "key-type:master-key-name"

format:= 'default | ecryptfs'
key-type:= 'trusted' | 'user'

\
 
 \ /
  Last update: 2013-11-14 19:41    [W:0.074 / U:0.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site