lkml.org 
[lkml]   [2013]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 6/9] KEYS: Trusted: Use key preparsing
Date
Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:

> > - * trusted_instantiate - create a new trusted key
> > + * trusted_preparse - Preparse data for an trusted key
> > *
> > - * Unseal an existing trusted blob or, for a new key, get a
> > - * random key, then seal and create a trusted key-type key,
> > - * adding it to the specified keyring.
> > + * Decrypt an existing encrypted datablob or create a new encrypted key
> > + * based on a kernel random number.
>
> Not sure why the change in terminology from unsealing/trusted blob to
> decrypt/encrypted blob.

Because the "Unseal an existing trusted blob ..." bit is still attached to the
trusted_instantiate() function. However, even what I wrote is still not a
good description of the trusted_preparse(), so I'll reduce it to just:

/*
* trusted_preparse - Preparse the payload data for an trusted key
*
* On success, return 0. Otherwise return errno.
*/

> trusted_preparse() always fails, since ret is initialized to -ENOMEM and
> never set.

Fixed.

Thanks,
David


\
 
 \ /
  Last update: 2013-11-14 17:41    [W:0.162 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site