Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 6/9] KEYS: Trusted: Use key preparsing | Date | Thu, 14 Nov 2013 15:50:59 +0000 |
| |
Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
> > - * trusted_instantiate - create a new trusted key > > + * trusted_preparse - Preparse data for an trusted key > > * > > - * Unseal an existing trusted blob or, for a new key, get a > > - * random key, then seal and create a trusted key-type key, > > - * adding it to the specified keyring. > > + * Decrypt an existing encrypted datablob or create a new encrypted key > > + * based on a kernel random number. > > Not sure why the change in terminology from unsealing/trusted blob to > decrypt/encrypted blob.
Because the "Unseal an existing trusted blob ..." bit is still attached to the trusted_instantiate() function. However, even what I wrote is still not a good description of the trusted_preparse(), so I'll reduce it to just:
/* * trusted_preparse - Preparse the payload data for an trusted key * * On success, return 0. Otherwise return errno. */
> trusted_preparse() always fails, since ret is initialized to -ENOMEM and > never set.
Fixed.
Thanks, David
| |