lkml.org 
[lkml]   [2013]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[tip:perf/urgent] tools/perf/build: Fix timerfd feature check
Commit-ID:  bb4c5500c9c5b809696eee212843e731721a6e15
Gitweb: http://git.kernel.org/tip/bb4c5500c9c5b809696eee212843e731721a6e15
Author: Ingo Molnar <mingo@kernel.org>
AuthorDate: Thu, 14 Nov 2013 08:33:24 +0100
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 14 Nov 2013 13:36:00 +0100

tools/perf/build: Fix timerfd feature check

'feature_timerfd' is checked all the time and calculated explicitly,
in a serial fashion. Add it to CORE_FEATURE_TESTS which causes it to
be built in parallel, using the newfangled parallel build autodetection
code.

This shaves 137 msecs off the perf build time on my system, which
speeds up the common case cached build by 43%:

Before:

comet:~/tip> perf stat --null --repeat 5 make -C tools/perf/
[...]
0,453771441 seconds time elapsed ( +- 0,09% )

After:

comet:~/tip> perf stat --null --repeat 5 make -C tools/perf/
[...]
0,316290185 seconds time elapsed ( +- 0,24% )

Cc: David Ahern <dsahern@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/n/tip-bb92CmexihopoSyqnkqepvsy@git.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
tools/perf/config/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index f5905f2..861379e 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -142,7 +142,8 @@ CORE_FEATURE_TESTS = \
libunwind \
on-exit \
stackprotector \
- stackprotector-all
+ stackprotector-all \
+ timerfd

#
# So here we detect whether test-all was rebuilt, to be able
@@ -405,7 +406,6 @@ else
endif
endif

-$(call feature_check,timerfd)
ifeq ($(feature-timerfd), 1)
CFLAGS += -DHAVE_TIMERFD_SUPPORT
else

\
 
 \ /
  Last update: 2013-11-14 14:01    [W:0.166 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site