Messages in this thread |  | | Date | Thu, 14 Nov 2013 11:12:45 +0000 | From | Mark Rutland <> | Subject | Re: [PATCH 4/5 v2] input: tc3589x-keypad: support probing from device tree |
| |
On Wed, Nov 13, 2013 at 11:29:24PM +0000, Sebastian Reichel wrote: > Hi, > > On Wed, Nov 13, 2013 at 02:24:06PM +0000, Mark Rutland wrote: > > > Current suggestions (taken from kernel) are: > > > > > > * <<vendor>>,no-autorepeat > > > * keypad,autorepeat > > > * linux,keypad-no-autorepeat > > > * linux,input-no-autorepeat > > > * linux,no-autorepeat > > > * autorepeat > > > > > > I do not really care, which one is chosen, except for two things: > > > > > > * <<vendor>> seems wrong. This is not vendor specific. > > > * I would prefer "input-" over "keypad-", since then the same name > > > can be used for single keys, buttons, etc. > > > > Both of those sound valid to me, but I think it may make sense to keep > > the "linux," prefix. As I understand it this is really telling the Linux > > input subsystem to react to a device acting in a certain way, rather > > than describing or configuring the device in a certain way. > > That leaves the following two options: > > * linux,input-no-autorepeat > * linux,no-autorepeat > > Any suggestions for those?
I'd go for "linux,input-no-autorepeat", it leaves less ambiguity as to its purpose.
Mark.
|  |