lkml.org 
[lkml]   [2013]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] spi: spi-gpio: Add check for cs-gpios dt property
Date
The bindings assumed that the cs-gpios property is always there.
However, a single SPI device can also work fine without an explicit chip select.
Use the SPI_GPIO_NO_CHIPSELECT mode when the property is not present or invaild.

Signed-off-by: Gerlando Falauto <gerlando.falauto@keymile.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-gpio.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-gpio.c b/drivers/spi/spi-gpio.c
index 0021fc4..3f21208 100644
--- a/drivers/spi/spi-gpio.c
+++ b/drivers/spi/spi-gpio.c
@@ -463,9 +463,16 @@ static int spi_gpio_probe(struct platform_device *pdev)
* property of the node.
*/

- for (i = 0; i < SPI_N_CHIPSEL; i++)
+ for (i = 0; i < SPI_N_CHIPSEL; i++) {
spi_gpio->cs_gpios[i] =
of_get_named_gpio(np, "cs-gpios", i);
+ if ((SPI_N_CHIPSEL == 1)
+ && !gpio_is_valid(spi_gpio->cs_gpios[i] < 0)) {
+ dev_info(&pdev->dev,
+ "no cs-gpios property, using no-cs mode\n");
+ spi_gpio->cs_gpios[i] = SPI_GPIO_NO_CHIPSELECT;
+ }
+ }
}
#endif

--
1.8.0.1


\
 
 \ /
  Last update: 2013-11-13 09:41    [W:0.052 / U:14.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site